I am not a fan of formal photos, or for that matter the ship's photo staff in general. I prefer my own casual snapshots since they mean more to me as a record of the cruise than some stiff posed photo with a fake seascape in the background.
I don't mind the formal photo. We usually head out to dinner a little early for formal photos and there's normally not much of a wait. We take only two photos and there are free in our Ultimate Booklet. Other than that the unscripted shots are better.
Regent got rid of ship's photographers around five years ago. Not too long after that they pretty much did away with formal nights, too. Don't miss the photographers; don't really miss dressing up either although I always take a sports coat and did need tux on a recent cruise.
I am not for or against the formal photos but my DW likes to get one or two.
It does not bother me in the least to have our picture taken.
Carnival Liberty New Year's Eve 2007
Liberty of the Seas 5/2008+11/2009
Allure 1/16/ 2011
Vision OTS 2-14-2015
Freedom OTS 3/6/16